<html>
<head><meta charset="utf-8"><title>style changes · t-compiler · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/index.html">t-compiler</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/style.20changes.html">style changes</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="155352159"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/style%20changes/near/155352159" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alexander Regueiro <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/style.20changes.html#155352159">(Jan 17 2019 at 17:16)</a>:</h4>
<p><span class="user-mention" data-user-id="116083">@pnkfelix</span> <span class="user-mention" data-user-id="125250">@Wesley Wiser</span> <span class="user-mention" data-user-id="116009">@nikomatsakis</span> Let me know how you want to categorise changes and I’ll factor them out into separate commits.</p>



<a name="155356519"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/style%20changes/near/155356519" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Wesley Wiser <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/style.20changes.html#155356519">(Jan 17 2019 at 18:21)</a>:</h4>
<p><span class="user-mention" data-user-id="124069">@Alexander Regueiro</span> Just skimming through the first couple files in your PR, I'd like to see individual commits for each of these:</p>
<ul>
<li>Url to issue number (I'm personally not a fan of this change TBH)</li>
<li>Capitalization fixes</li>
<li>Adding markdown formatting </li>
<li>Two spaces after <code>.</code> to one space</li>
<li>Proper punctuation</li>
<li>The <code>true if</code> changes (probably better to leave this out given the controversy) </li>
<li>General whitespace changes</li>
<li>Etc</li>
</ul>
<p>Any changes to code should definitely go in their own commits.</p>
<p>My 2c</p>



<a name="155356758"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/style%20changes/near/155356758" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alexander Regueiro <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/style.20changes.html#155356758">(Jan 17 2019 at 18:24)</a>:</h4>
<p><span class="user-mention" data-user-id="125250">@Wesley Wiser</span> sounds reasonable. I'm going to implement the URL to issue number changes, since that represents the existing consensus in the codebase, but we can all debate later. Re <code>true if</code>, I'll normalise to that (even if I don't like it)</p>



<a name="155356977"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/style%20changes/near/155356977" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Wesley Wiser <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/style.20changes.html#155356977">(Jan 17 2019 at 18:28)</a>:</h4>
<p><span class="user-mention" data-user-id="124069">@Alexander Regueiro</span>  The other thing that might help you get this done quicker is to split up the changes by module or whatever. ljedrz has taken this approach and it seems to have worked well for them: <a href="https://github.com/rust-lang/rust/pulls?utf8=%E2%9C%93&amp;q=is%3Apr+author%3Aljedrz+cleanup" target="_blank" title="https://github.com/rust-lang/rust/pulls?utf8=%E2%9C%93&amp;q=is%3Apr+author%3Aljedrz+cleanup">https://github.com/rust-lang/rust/pulls?utf8=%E2%9C%93&amp;q=is%3Apr+author%3Aljedrz+cleanup</a></p>



<a name="155356993"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/style%20changes/near/155356993" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Wesley Wiser <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/style.20changes.html#155356993">(Jan 17 2019 at 18:29)</a>:</h4>
<p>People will be faster to review and approve smaller PRs than large ones</p>



<a name="155357279"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/style%20changes/near/155357279" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alexander Regueiro <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/style.20changes.html#155357279">(Jan 17 2019 at 18:32)</a>:</h4>
<p><span class="user-mention" data-user-id="125250">@Wesley Wiser</span> okay, sounds fair, ta</p>



<a name="156324721"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/style%20changes/near/156324721" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/style.20changes.html#156324721">(Jan 17 2019 at 22:24)</a>:</h4>
<p>(I broke out a topic for this)</p>



<a name="156359937"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/style%20changes/near/156359937" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> varkor <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/style.20changes.html#156359937">(Jan 18 2019 at 11:01)</a>:</h4>
<p>(for the record, I think I'd prefer normalising issue numbers to URLs rather than vice versa, as they're more convenient to access)</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>